Skip to content

8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324 #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented Mar 11, 2025

Hi all,

This PR fixes the wrong version of Xerces-J.
The version of Xerces-J became 2.7.1 in JDK-7150324, but it is 2.10.0 in THIRD_PARTY_README.
Just fix THIRD_PARTY_README, no risk.

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8351624 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/636/head:pull/636
$ git checkout pull/636

Update a local copy of the PR:
$ git checkout pull/636
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 636

View PR using the GUI difftool:
$ git pr show -t 636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/636.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2025

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@kurashige23
Copy link
Member Author

Could anyone review this PR please?

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2025

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@kurashige23
Copy link
Member Author

Could anyone review this PR please?

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@kurashige23
Copy link
Member Author

kurashige23 commented Jun 8, 2025

@jerboaa

I'm sorry to bother you suddenly, but could you please review this PR?
Or could you assign a reviewer?
I'm having trouble because I haven't had any reviewers for a while.

Thanks.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Reasoning explained in the bug makes sense.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@kurashige23
Copy link
Member Author

Thank you for your review!

/approval request The version of Xerces-J is wrong in THIRD_PARTY_README after JDK-7150324, so I fxied it. Just fix THIRD_PARTY_README, no risk.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@kurashige23
8351624: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 10, 2025
@kurashige23
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 10, 2025
@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@kurashige23
Your change (at version 70e695e) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Jun 10, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

Going to push as commit 4f92342.
Since your change was applied there have been 40 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 10, 2025
@openjdk openjdk bot closed this Jun 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 10, 2025
@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@jerboaa @kurashige23 Pushed as commit 4f92342.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants