Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Dec 12, 2024

…stTest.java fails with jtreg5.1

Tests fixed to be compatible with jtreg 5.1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346140 needs maintainer approval

Issue

  • JDK-8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/612/head:pull/612
$ git checkout pull/612

Update a local copy of the PR:
$ git checkout pull/612
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 612

View PR using the GUI difftool:
$ git pr show -t 612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/612.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManife… 8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 Dec 12, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

Copy link
Member

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run passed with jtreg5.1

sendaoYan added a commit to sendaoYan/aqa-tests that referenced this pull request Dec 20, 2024
Problemlist tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java in jdk8u before the upstream test-fix [PR](openjdk/jdk8u-dev#612) has been integrated. The two tests fails with jtreg5.1.

Fixes: adoptium#5831
Signed-off-by: sendaoYan <[email protected]>
LongyuZhang pushed a commit to adoptium/aqa-tests that referenced this pull request Dec 20, 2024
…k8u (#5832)

Problemlist tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java in jdk8u before the upstream test-fix [PR](openjdk/jdk8u-dev#612) has been integrated. The two tests fails with jtreg5.1.

Fixes: #5831

Signed-off-by: sendaoYan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants