-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test #518
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
GHA test failures appear unrelated. |
/approval request This patch complements JDK-8268457, which I have already proposed for backporting. |
@ktakakuri |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8274606
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@ktakakuri this pull request can not be integrated into git checkout 8274606
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
I resolved the conflicts. |
This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test.
This patch complements JDK-8268457, which I have already proposed for backporting. #517
This backport is not clean due to the fact that the JDK-8268457 backport is not clean.
I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it.
Testing: All tests under jdk/test/javax/xml/jaxp/
Thank you.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/518/head:pull/518
$ git checkout pull/518
Update a local copy of the PR:
$ git checkout pull/518
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/518/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 518
View PR using the GUI difftool:
$ git pr show -t 518
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/518.diff
Using Webrev
Link to Webrev Comment