-
Notifications
You must be signed in to change notification settings - Fork 160
8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging" #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
Please look at the test errors in GHAs and check them. Provided they have nothing to do with the patch, my approval still stands. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Some tests are failing in GHA, but they are irrelevant as they are related to certification or GC. |
/approval request Fix Request 8u |
@ktakakuri |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@ktakakuri The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved. |
/open |
@ktakakuri This pull request is now open |
Given #428 breaks the build because this function is not present on VS2010, I think this change should go in before #428, not after. @ktakakuri can you update this PR to apply against latest master, so we can get it in? Thanks. |
I changed the branch to merge into to master. |
This reverts commit b62ee29.
I reverted JDK-8159695 fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating. Change looks good to me.
/approve yes |
@gnu-andrew |
/integrate |
@ktakakuri |
/sponsor |
Going to push as commit 44eac48.
Your commit was automatically rebased without conflicts. |
@phohensee @ktakakuri Pushed as commit 44eac48. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
I worked on backporting JDK-8159695 to jdk8u ( #428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
The risk is low as this only affects earlier VS builds and introduces one macro.
Testing: GHA
Thank you.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/434/head:pull/434
$ git checkout pull/434
Update a local copy of the PR:
$ git checkout pull/434
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/434/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 434
View PR using the GUI difftool:
$ git pr show -t 434
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/434.diff
Webrev
Link to Webrev Comment