Skip to content

8312065: Socket.connect does not timeout when profiling #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yanglong1010
Copy link
Contributor

@yanglong1010 yanglong1010 commented Dec 21, 2023

Hi,

This pull request contains the backport of JDK-8312065, commit 1ce12c4 from the openjdk/jdk17u-dev repository.

I added the test B8312065.java. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix.
This test relies on libNativeThread to get the OS thread ID of the Java threads, and send signals to OS threads.
The libNativeThread was introduced to test the fix for JDK-8237858. However, JDK-8237858 only exists in Java 10 and above. There is no JDK-8237858 problem on Java 8, so JDK-8237858 cannot be backported to Java 8.
In order to use libNativeThread, I copied it to my backport.

I ran all the jtreg tests in test/jdk/java/net/ServerSocket,test/jdk/java/net/Socket,test/jdk/java/net/SocketOption,test/jdk/java/net/ipv6 on my host, all passed.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312065 needs maintainer approval

Issue

  • JDK-8312065: Socket.connect does not timeout when profiling (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/410/head:pull/410
$ git checkout pull/410

Update a local copy of the PR:
$ git checkout pull/410
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 410

View PR using the GUI difftool:
$ git pr show -t 410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/410.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2023

👋 Welcome back yanglong1010! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2023
@yanglong1010 yanglong1010 changed the title 8312065: Socket.connect does not timeout as expected when profiling Backport 1ce12c4f33d3d6905703d95df2574f4037dfd57d Dec 21, 2023
@openjdk openjdk bot changed the title Backport 1ce12c4f33d3d6905703d95df2574f4037dfd57d 8312065: Socket.connect does not timeout when profiling Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 21, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2024

@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yanglong1010
Copy link
Contributor Author

Gentle ping. Is anyone willing to help review this?

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2024

@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yanglong1010
Copy link
Contributor Author

Gentle ping. Is anyone willing to help review this?

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yanglong1010
Copy link
Contributor Author

Gentle ping. I would be very grateful if anyone could help with the review.

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2024

@yanglong1010 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 6, 2024
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@phohensee
Copy link
Member

/keepalive

@openjdk
Copy link

openjdk bot commented May 14, 2025

@phohensee This command can only be used in open pull requests.

@phohensee
Copy link
Member

/touch

@openjdk
Copy link

openjdk bot commented May 14, 2025

@phohensee This command can only be used in open pull requests.

@yanglong1010
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

@yanglong1010 This pull request is now open

@yanglong1010
Copy link
Contributor Author

@phohensee I didn't see your approval. Is it because this pull request has been closed by bot. I've reopened it, would you try again ?

@yanglong1010
Copy link
Contributor Author

/approval 8312065 request I would like to backport this fix to jdk8u-dev.
Low risk: Do not perform redundant loop retries for NET_Poll. Existing tests have proven that it does not affect the original functions, and a dedicated test for this issue has been added.
Testing: All GHA tests are passed. I ran all the jtreg tests (test/jdk/java/net/ServerSocket,test/jdk/java/net/Socket,test/jdk/java/net/SocketOption,test/jdk/java/net/ipv6) related to jdk.net.usePlainSocketImpl on my host, all passed.
Clean backport.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@yanglong1010
8312065: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 30, 2025
@phohensee
Copy link
Member

Done. Hit the wrong button. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants