-
Notifications
You must be signed in to change notification settings - Fork 160
8312065: Socket.connect does not timeout when profiling #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back yanglong1010! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Gentle ping. Is anyone willing to help review this? |
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Gentle ping. Is anyone willing to help review this? |
❗ This change is not yet ready to be integrated. |
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Gentle ping. I would be very grateful if anyone could help with the review. |
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@yanglong1010 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
/keepalive |
@phohensee This command can only be used in open pull requests. |
/touch |
@phohensee This command can only be used in open pull requests. |
/open |
@yanglong1010 This pull request is now open |
@phohensee I didn't see your approval. Is it because this pull request has been closed by bot. I've reopened it, would you try again ? |
/approval 8312065 request I would like to backport this fix to jdk8u-dev. |
@yanglong1010 |
Done. Hit the wrong button. :) |
Hi,
This pull request contains the backport of JDK-8312065, commit 1ce12c4 from the openjdk/jdk17u-dev repository.
I added the test
B8312065.java
. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix.This test relies on libNativeThread to get the
OS thread ID
of theJava threads
, and send signals toOS threads
.The
libNativeThread
was introduced to test the fix for JDK-8237858. However,JDK-8237858
only exists in Java 10 and above. There is noJDK-8237858
problem on Java 8, soJDK-8237858
cannot be backported to Java 8.In order to use
libNativeThread
, I copied it to my backport.I ran all the
jtreg
tests intest/jdk/java/net/ServerSocket
,test/jdk/java/net/Socket
,test/jdk/java/net/SocketOption
,test/jdk/java/net/ipv6
on my host, all passed.Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/410/head:pull/410
$ git checkout pull/410
Update a local copy of the PR:
$ git checkout pull/410
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/410/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 410
View PR using the GUI difftool:
$ git pr show -t 410
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/410.diff
Using Webrev
Link to Webrev Comment