Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link

@fmeum fmeum commented Dec 16, 2024

Hi all,

This pull request contains a backport of commit d7ef3ac0 from the openjdk/jdk repository.

The commit being backported was authored by Fabian Meumertzheim on 9 Dec 2024 and was reviewed by David Holmes, Kevin Walls and Severin Gehwolf.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345684 needs maintainer approval

Issue

  • JDK-8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/jdk24u.git pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/4.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back fmeum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d7ef3ac0b7e677c4901c69ad4361b5de8408e8d3 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

⚠️ @fmeum This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@fmeum
Copy link
Author

fmeum commented Dec 16, 2024

/approval request This is a safe fix (additional null check) for a flaky unexpected NPE.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@fmeum
8345684: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant