Skip to content

8326705: Test CertMsgCheck.java fails to find alert certificate_required #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pr/2069
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 11, 2025

Follow up to JDK-8311644.

Resolved problemlist, test was not listed.
Test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326705 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2069 must be integrated first

Issue

  • JDK-8326705: Test CertMsgCheck.java fails to find alert certificate_required (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2070/head:pull/2070
$ git checkout pull/2070

Update a local copy of the PR:
$ git checkout pull/2070
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2070

View PR using the GUI difftool:
$ git pr show -t 2070

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2070.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2069 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 4ffc5e60776353b03e9a557c39148e378b1690e2 8326705: Test CertMsgCheck.java fails to find alert certificate_required Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 11, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8326705 branch from 19ac618 to f25abf6 Compare August 11, 2025 08:21
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

⚠️ @GoeLin This backport pull request is too large to be automatically evaluated as clean.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants