-
Notifications
You must be signed in to change notification settings - Fork 133
8309953: Strengthen and optimize oopDesc age methods #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of 4a5475ce0492fc02019b0f89b50601c388c63e21. Minor gc perf improvement when it's on a hot path: See the benchmark in comment: openjdk/jdk#14456 (comment) The backport applies cleanly. Tested with tier 1. In mainline for 2 years. The risk is low. |
@rgithubli |
@rgithubli This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
https://bugs.openjdk.org/browse/JDK-8309953
A clean backport. An minor optimization for oopDesc age.
tier 1 passed locally. The logic is simple - store the
mark()
value into a var so we don't read it twice. The original commit is in tip for almost 2 years. Low risk.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1950/head:pull/1950
$ git checkout pull/1950
Update a local copy of the PR:
$ git checkout pull/1950
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1950/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1950
View PR using the GUI difftool:
$ git pr show -t 1950
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1950.diff
Using Webrev
Link to Webrev Comment