Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners #1159

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Nov 18, 2024

Clean backport of JDK-8343923. Required because of actions/runner-images#10703. Local build with Xcode 15.4 on a MacBook Pro M1 has worked.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343923 needs maintainer approval

Issue

  • JDK-8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1159/head:pull/1159
$ git checkout pull/1159

Update a local copy of the PR:
$ git checkout pull/1159
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1159

View PR using the GUI difftool:
$ git pr show -t 1159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1159.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 948710f: 8338389: [JFR] Long strings should be added to the string pool
  • b9c83b5: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • a4927ca: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
  • f36b3b4: 8336911: ZGC: Division by zero in heuristics after JDK-8332717
  • 4f6c506: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 38f654e: 8343724: [PPC64] Disallow OptoScheduling
  • 1bfb57d: 8342607: Enhance register printing on x86_64 platforms
  • fe41d0a: 8343506: [s390x] multiple test failures with ubsan
  • e1eb341: 8342183: Update tests to use stronger algorithms and keys
  • 0fd3173: 8342188: Update tests to use stronger key parameters and certificates
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/bcc85d923fffe37546caa4a738d8fdbce745dd45...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4c5bc5f2f091ae861d5329cdae42fe7fa295544b 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Nov 18, 2024

/approval request Only GHA update. Clean backport. GHA tests have passed.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@TheRealMDoerr
8343923: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Nov 18, 2024
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Nov 18, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

Going to push as commit 4b1365e.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 948710f: 8338389: [JFR] Long strings should be added to the string pool
  • b9c83b5: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • a4927ca: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
  • f36b3b4: 8336911: ZGC: Division by zero in heuristics after JDK-8332717
  • 4f6c506: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 38f654e: 8343724: [PPC64] Disallow OptoScheduling
  • 1bfb57d: 8342607: Enhance register printing on x86_64 platforms
  • fe41d0a: 8343506: [s390x] multiple test failures with ubsan
  • e1eb341: 8342183: Update tests to use stronger algorithms and keys
  • 0fd3173: 8342188: Update tests to use stronger key parameters and certificates
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/bcc85d923fffe37546caa4a738d8fdbce745dd45...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2024
@openjdk openjdk bot closed this Nov 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@TheRealMDoerr Pushed as commit 4b1365e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant