8211804: Constant AO_UNUSED_MBZ uses left shift of negative value

[mrserb]

Hi all,

This pull request contains a backport of commit 51be7db9 from the openjdk/jdk repository.

The commit being backported was authored by Kim Barrett on 9 Oct 2018 and was reviewed by Alan Bateman.

This patch fixes a build error on macOS with Xcode 16.4 that can't be resolved using --disable-warnings-as-errors.

/jdk11u-dev/src/jdk.pack/share/native/common-unpack/constants.h:206:33: error: expression is not an integral constant expression
  206 |     AO_UNUSED_MBZ             = (-1)<<13, // options bits reserved for future use.
      |                                 ^~~~~~~~

Thanks!

---

Progress

• JDK-8211804 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8211804: Constant AO_UNUSED_MBZ uses left shift of negative value (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3042/head:pull/3042
$ git checkout pull/3042

Update a local copy of the PR:
$ git checkout pull/3042
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3042/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3042

View PR using the GUI difftool:
$ git pr show -t 3042

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3042.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211804: Constant AO_UNUSED_MBZ uses left shift of negative value

Use unsigned shift.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 098d324: 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest
• 694f561: 8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected"
• a7e7709: 8340185: Use make -k on GHA to catch more build errors
• ... and 21 more: https://git.openjdk.org/jdk11u-dev/compare/c5407b6a8464fcc1eed31a2e9e30651e9011dbd3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

/approval request Clean backport. Fix for a broken build on macOS + XCode 16.4

[openjdk]

@mrserb
8211804: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (fc00dffd)

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

/keepalive

[openjdk]

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!