8353276: C2: simplify PhaseMacroExpand::opt_bits_test #26276
+5
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back snatarajan! A progress list of the required criteria for merging this PR into |
|
@sarannat This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
chhagedorn
approved these changes
Jul 14, 2025
src/hotspot/share/opto/macro.cpp
Outdated
Comment on lines
97
to
98
| Node* cmp; | ||
| if (mask != 0) { | ||
| Node* and_node = transform_later(new AndXNode(word, MakeConX(mask))); | ||
| cmp = transform_later(new CmpXNode(and_node, MakeConX(bits))); | ||
| } else { | ||
| cmp = word; | ||
| } | ||
| cmp = word; |
There was a problem hiding this comment.
Could now be merged (I cannot make a direct suggestion due to deleted lines):
Node* cmp = word;
There was a problem hiding this comment.
Thank you. I have addressed this in the new commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The last three parameters of
PhaseMacroExpand::opt_bits_test(Node* ctrl, Node* region, int edge, Node* word, int mask, int bits, bool return_fast_path)are unnecessary after the fix introduced in JDK-8256425Fix
The proposed fix removes the last three parameters and makes the necessary modification to the methods.
Testing
GitHub Actions
tier1 to tier5 on windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26276/head:pull/26276$ git checkout pull/26276Update a local copy of the PR:
$ git checkout pull/26276$ git pull https://git.openjdk.org/jdk.git pull/26276/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26276View PR using the GUI difftool:
$ git pr show -t 26276Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26276.diff
Using Webrev
Link to Webrev Comment