8320622: [TEST] Improve coverage of compiler/loopopts/superword/TestMulAddS2I.java on different platforms

[fg1417]

It would be worthwhile to improve the test coverage on all platforms by applying another common VM flag.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320622: [TEST] Improve coverage of compiler/loopopts/superword/TestMulAddS2I.java on different platforms (Enhancement - P4)

Reviewers

• Emanuel Peter (@eme64 - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19305/head:pull/19305
$ git checkout pull/19305

Update a local copy of the PR:
$ git checkout pull/19305
$ git pull https://git.openjdk.org/jdk.git pull/19305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19305

View PR using the GUI difftool:
$ git pr show -t 19305

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19305.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fgao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fg1417 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320622: [TEST] Improve coverage of compiler/loopopts/superword/TestMulAddS2I.java on different platforms

Reviewed-by: epeter, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• 52eda79: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
• d999b81: 8331572: Allow using OopMapCache outside of STW GC phases
• 8291c94: 8331224: ClassCastException in ObjectInputStream hides ClassNotFoundException
• 42e3c84: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
• 5cf8288: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
• ae9ad86: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
• 3479b46: 8332595: Serial: Remove unused TenuredGeneration::should_collect
• 9bfae88: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
• 4e169d1: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
• 7ffc999: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
• ... and 38 more: https://git.openjdk.org/jdk/compare/fa3e94d30f11bdccbe290041ae19490ce4940bb1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@fg1417 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (942d67d4)

[eme64]

Welcome back, long time no see ☺️

Looks good to me!

[fg1417]

Welcome back, long time no see ☺️

Looks good to me!

Thanks @eme64 ! Happy to see you again ☺️

[vnkozlov]

Are all platforms support both (true and false) values of AlignVector?
I see it is only adjusted for x86 and aarch64 in vm_version_<cpu>.cpp files.

[fg1417]

Are all platforms support both (true and false) values of AlignVector? I see it is only adjusted for x86 and aarch64 in vm_version_<cpu>.cpp files.

Thanks for your review @vnkozlov . Yeah, and AlignVector only works by the return value here,

jdk/src/hotspot/share/opto/superword.hpp

Line 575 in d6b7f9b

bool vectors_should_be_aligned() { return !Matcher::misaligned_vectors_ok() || AlignVector; }

. Matcher::misaligned_vectors_ok() is architecture dependent. AlignVector is true by default. When we sets false by cmd line, if the platform doesn't support misaligned load/store, Matcher::misaligned_vectors_ok() should return false and the actual value of vectors_should_be_aligned() is still true . It should be okay to set true or false on all platforms. WDYT?

[offamitkumar]

I have tested it on s390x, look good for us.

[vnkozlov]

Good.

[fg1417]

Thanks for your review @vnkozlov @eme64 @offamitkumar .

I'm going to integrate it.

[fg1417]

/integrate

[openjdk]

Going to push as commit 8a9d77d.
Since your change was applied there have been 51 commits pushed to the master branch:

• 3d511ff: 8329748: Change default value of AssertWXAtThreadSync to true
• 67f03f2: 8332533: RISC-V: Enable vector variable shift instructions for machines with RVV
• 5f804b2: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER
• 52eda79: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
• d999b81: 8331572: Allow using OopMapCache outside of STW GC phases
• 8291c94: 8331224: ClassCastException in ObjectInputStream hides ClassNotFoundException
• 42e3c84: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
• 5cf8288: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
• ae9ad86: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
• 3479b46: 8332595: Serial: Remove unused TenuredGeneration::should_collect
• ... and 41 more: https://git.openjdk.org/jdk/compare/fa3e94d30f11bdccbe290041ae19490ce4940bb1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fg1417 Pushed as commit 8a9d77d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.