8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct

[offamitkumar]

format method generated previously:

void partialSubtypeCheckConstSuperNode::format(PhaseRegAlloc *ra, outputStream *st) const {
  // Start at oper_input_base() and count operands
  unsigned idx0 = 1;
  unsigned idx1 = 1; 	// sub
  unsigned idx2 = idx1 + opnd_array(1)->num_edges(); 	// super_reg
  unsigned idx3 = idx2 + opnd_array(2)->num_edges(); 	// super_con
  unsigned idx4 = idx3 + opnd_array(3)->num_edges(); 	// vtemp
  unsigned idx5 = idx4 + opnd_array(4)->num_edges(); 	// tempR1
  unsigned idx6 = idx5 + opnd_array(5)->num_edges(); 	// tempR2
  unsigned idx7 = idx6 + opnd_array(6)->num_edges(); 	// tempR3
  st->print_raw("partialSubtypeCheck ");
  opnd_array(0)->int_format(ra, this, st); // result
  st->print_raw(", ");
  opnd_array(1)->ext_format(ra, this,idx1, st); // sub
  st->print_raw(", super");
}

format method generated with this change:

void partialSubtypeCheckConstSuperNode::format(PhaseRegAlloc *ra, outputStream *st) const {
  // Start at oper_input_base() and count operands
  unsigned idx0 = 1;
  unsigned idx1 = 1; 	// sub
  unsigned idx2 = idx1 + opnd_array(1)->num_edges(); 	// super_reg
  unsigned idx3 = idx2 + opnd_array(2)->num_edges(); 	// super_con
  unsigned idx4 = idx3 + opnd_array(3)->num_edges(); 	// vtemp
  unsigned idx5 = idx4 + opnd_array(4)->num_edges(); 	// tempR1
  unsigned idx6 = idx5 + opnd_array(5)->num_edges(); 	// tempR2
  unsigned idx7 = idx6 + opnd_array(6)->num_edges(); 	// tempR3
  st->print_raw("partialSubtypeCheck ");
  opnd_array(0)->int_format(ra, this, st); // result
  st->print_raw(", ");
  opnd_array(1)->ext_format(ra, this,idx1, st); // sub
  st->print_raw(", ");
  opnd_array(2)->ext_format(ra, this,idx2, st); // super_reg
  st->print_raw(", ");
  opnd_array(3)->ext_format(ra, this,idx3, st); // super_con
}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19295/head:pull/19295
$ git checkout pull/19295

Update a local copy of the PR:
$ git checkout pull/19295
$ git pull https://git.openjdk.org/jdk.git pull/19295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19295

View PR using the GUI difftool:
$ git pr show -t 19295

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19295.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 5f2b8d0: 8332448: Make SpaceMangler inherit AllStatic
• 8a49d47: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
• b78613b: 8332154: Memory leak in SynchronousQueue
• 7652f98: 8331885: C2: meet between unloaded and speculative types is not symmetric
• d6b7f9b: 8331851: Add specific regression leap year tests for Calendar.roll()
• ... and 14 more: https://git.openjdk.org/jdk/compare/f1ce9b0ecce9b506f5bf7a66fcf03c93b9ae8fed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@offamitkumar The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e550d5f)

[offamitkumar]

@theRealAph would you review this trivial fix.

[vnkozlov]

Good for x64 and aarch64. And you need Andrew's approval too.

[TobiHartmann]

Looks good to me too.

[offamitkumar]

Thanks Tobias & Vladimir for review. I guess we are good to go now as we have 2 reviews.

/integrate

[openjdk]

Going to push as commit 7ffc999.
Since your change was applied there have been 27 commits pushed to the master branch:

• e529101: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
• 414a7fd: 8311175: Move BufWriter::asByteBuffer to BufWriterImpl
• 451cc23: 8332486: ClassFile API ArrayIndexOutOfBoundsException with label metadata
• 5f2b8d0: 8332448: Make SpaceMangler inherit AllStatic
• 8a49d47: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
• ... and 17 more: https://git.openjdk.org/jdk/compare/f1ce9b0ecce9b506f5bf7a66fcf03c93b9ae8fed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@offamitkumar Pushed as commit 7ffc999.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.