Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axi Specification: Modify the AXI memory interface specification #1960

Merged
merged 1 commit into from
May 27, 2024

Conversation

AEzzejjari
Copy link
Member

Modify AXI interface specification by adding constraint that are not supported by CVA6

Copy link
Contributor

✔️ successful run, report available here.

Copy link
Contributor

@jquevremont jquevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jquevremont
Copy link
Contributor

@JeanRochCoulon, can you merge if you agree?

@JeanRochCoulon JeanRochCoulon added the Status:Do-not-merge Pull request that should not be merged (yet) label Apr 16, 2024
@JeanRochCoulon
Copy link
Contributor

@ludovicpion This is our AXI specification. It would be useful if you could review it. You have the AXI knowledge, that could help us to improve the quality of the specification. Thanks

Copy link
Contributor

👋 Hi there!

This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊

@github-actions github-actions bot added the Status:Stale Issue or PR is stale and hasn't received any updates. label May 24, 2024
@JeanRochCoulon JeanRochCoulon removed the Status:Stale Issue or PR is stale and hasn't received any updates. label May 24, 2024
@JeanRochCoulon
Copy link
Contributor

@ludovicpion @AEzzejjari Thsi PR is open since a lon,g time, what is the status of this PR ?

@AEzzejjari
Copy link
Member Author

@JeanRochCoulon I think we can merge this PR. We didn't receive any feedback from CEA about the specification in their last review.

@JeanRochCoulon
Copy link
Contributor

@ludovicpion Any feedbacks ?

@JeanRochCoulon JeanRochCoulon merged commit f0deb61 into openhwgroup:master May 27, 2024
6 checks passed
@AEzzejjari AEzzejjari deleted the AXISpec branch May 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Do-not-merge Pull request that should not be merged (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants