[velbus] VMB8IN-20 implementation rewrite #18365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module VMBPIR-20 is missing in the readme. Signed-off-by: Daniel Rosengarten <[email protected]>
New functionality : - Add OnOff command type on Brightness channels for VMB4LEDPWM-20 Signed-off-by: Daniel Rosengarten <[email protected]>
Sending an ON command will switch the dimmer to the value stored when last turning the dimmer off. Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Use the same counter units than the VBM7IN module. Signed-off-by: Daniel Rosengarten <[email protected]>
lsiepel
requested changes
Mar 6, 2025
...ng.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMB8INHandler.java
Show resolved
Hide resolved
...ng.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMB8INHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.velbus/src/main/resources/OH-INF/config/8-channel-device-config.xml
Show resolved
Hide resolved
- Set this.refreshJob to null in dispose() method for the different modules. - Set units string to string constant in VMB8INHandler. Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMB8IN-20 module was wrongly implemented.
Access to a test module has permitted to correct the error.
Signed-off-by: Daniel Rosengarten [email protected]