[gree] Fixes - using refresh value from configuration and add encryption type - Combined #18360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhivka Dimova <[email protected]>
Create additional option for the users to select the encryption type Rewrite the Thing Configuration table - inappropriate table headers and content. Signed-off-by: Zhivka Dimova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a
Refresh Intervalproperty in the device's configurations, which wasn't used in the code. A default value of 5sec was used, so the code was retrieving the values from the AC every 5sec (sending a pull request) - changes in the first commit.Adding encryption type - Combined in the device's encryption configuration. Devices with firmware abode 1.23 are using
ECBdecryption for the scan response andGCMfor everything else, and the possibility to select eitherECBorGCMleads to a lot of errors when the communication with the device was interrupted and a new scan and binding is executed.The problem is reported here
Rewriting the Thing Configuration table in the
README.MDfile, because the table's headers were inappropriate.Testing
Here is a link to a generated jar file for testing on OH 4.3.