[mercedesme] UOM cleanup #18332
[mercedesme] UOM cleanup #18332
Conversation
bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/thing/eco-channel-types.xml
Outdated
Show resolved
Hide resolved
|
Other PR is merged, @weymann you can proceed with fixing the conflict etc. |
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
weymann
force-pushed
the
mercedesme-metadata-adjuster-remove
branch
from
4f629f3 to
7a4893d
Compare
|
Build runs fine now, ready to merge! |
| <item-type unitHint="%">Number:Dimensionless</item-type> | ||
| <label>Charge SoC Maximum</label> | ||
| <state pattern="%d %%"/> | ||
| <state pattern="%d %unit%"/> |
There was a problem hiding this comment.
Not sure if this is going to work. As the optionlist contains % as unit, setting the unit to anything different (like One) would cause issues.
There was a problem hiding this comment.
I had enough beef with UOM since the beginning.
It's not a hint to configure the max charge limit - it's a fact to configure as % and not one, db, ppm or whatever the user is capable to do!
If you choose something on your own - garbage in, garbage out
Do you have any advice to do it correctly?
There was a problem hiding this comment.
I would just revert this the way it was, percentage is the only correct unit.
There was a problem hiding this comment.
Isn't One also, i.e. 0.67 rather than 67%, if this is preferred?
There was a problem hiding this comment.
Isn't
Onealso, i.e. 0.67 rather than 67%, if this is preferred?
Correct, it's shown this way.
I would just revert this the way it was, percentage is the only correct unit.
The user can choose unit one and it shall not been shown as 0.8 %
In above screenshot you can see there's no unit displayed if unit one is choosed.
And if users chooses unit ppm then the state pattern will show 800000 ppm
Looks good for me, I would prefer to leave it this way.
bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/thing/eco-channel-types.xml
Show resolved
Hide resolved
MetaDataAdjusterclass is a relict before Units of Measure was introduced.Class for adjusting metadata is removed and
unitHintsin xml are provided.