Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Improve smoke sensor wake-up period handling #18309

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matmai
Copy link
Contributor

@matmai matmai commented Feb 21, 2025

To prevent shelly smoke sensors to go offline if they slightly exceed the reported wake up period (24 hours) the time limit is extended by 30 minutes for this kind of devices.

Fixes #17767

@matmai matmai requested a review from markus7017 as a code owner February 21, 2025 19:37
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Would be nice if @markus7017 could confirm

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 21, 2025
@lsiepel lsiepel changed the title [shelly] increase smoke sensor regular update period by half an hour [shelly] Improve smoke sensor wake-up period handling Feb 21, 2025
@matmai matmai force-pushed the 17767-shelly-smoke-wakeup branch from 73be9ca to d308a97 Compare February 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shelly] Shelly Plus Smoke update period
2 participants