Close loophole in validation of media_file_url

Closes #333
opengovernment · Feb 9, 2014 · a8a0f38 · a8a0f38
1 parent 8af6bd4
commit a8a0f38
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/app/models/question.rb b/app/models/question.rb
@@ -152,7 +152,11 @@ def copy_coordinates_from_user
   def modify_media_file_url_if_from_video_site
     if media_file_url.present? && !ImageSrcUrl.new(media_file_url).is_image?
       video_src_url = VideoSrcUrl.new(media_file_url)
-      self.media_file_url = video_src_url.value if video_src_url.is_video?
+      if video_src_url.is_video?
+        self.media_file_url = video_src_url.value
+      else
+        self.media_file_url = "Image or video for sure? #{media_file_url}"
+      end
     end
   end
 end