Skip to content

Lazy evaluation of the amber toolkit version #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vamironov
Copy link

Getting _toolkit_version involves expensive system call even if this property is not used. This patch saves few seconds of runtime in conda environments.

Getting `_toolkit_version` involves expensive system call even if this property is not used. This patch saves few seconds of runtime in conda environments.
@vamironov vamironov requested a review from j-wags as a code owner June 3, 2025 22:30
@mattwthompson
Copy link
Member

Thanks for the patch - I'll have a look soon

(Don't worry about half of the CI failing, some of our tests require an OpenEye license that's not accessible on forks)

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (713cfa9) to head (310c6c6).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants