Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer some third-party imports for quicker high-level imports #1085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Defer some third-party imports for quicker high-level imports #1085

wants to merge 1 commit into from
+30 −23

Conversation

mattwthompson
Copy link
Member

Description

Resolves #239, for now?

I mean, we could defer loading openff.toolkit.ForceField but that seems obtuse

Checklist

  • Add tests
  • Lint
  • Update docstrings

@mattwthompson
Copy link
Member Author

image

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (dca833b) to head (b97aecb).
Report is 9 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review October 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup: Slow import times
1 participant
@mattwthompson