fix: changes in remove_bad_nearly_empty_products_wo_images

[alexgarel]

I get this change from current production.

I kept it there, but I was wondering if it's to be kept or not.

cc: @stephanegigandet

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
5913	2	5911	0

View the top 2 failed test(s) by shortest run time

tests_unit_knowledge_panels_t::Test Plan Failure

Stack Traces | 19.7s run time

No plan was declared

tests_unit_knowledge_panels_t::0003 - UNKNOWN_TEST?

Stack Traces | 26.7s run time

not ok 0003 - UNKNOWN_TEST?

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[CharlesNepote]

Still struggling with this and I would need you advises: @stephanegigandet and @alexgarel.

The script is working like this:

1. At first, ./remove_bad_nearly_empty_products_wo_images.pl --test is identifying products which have to be deleted, pushing the results to STDOUT
2. Then ./remove_bad_nearly_empty_products_wo_images.pl --misc is tagging each product to be deleted.
3. Then reviewers can have a look to products that can be deleted, and validate the removal of all products.
4. The removal is finally made with ./remove_bad_nearly_empty_products_wo_images.pl --remove

My concern is about stage 3: if reviewers identify products that should not be deleted, they should remove the tag.
At first I was using the tag /facets/misc/en:bad-product-wo-image-to-be-deleted BUT reviewers can't edit the misc field.
So in this current test, I'm using facets/categories/en:bad-product-wo-image-to-be-deleted:

• the reviewers can manually remove the category
• BUT adding a category increases the completeness (is it by 0.1 @stephanegigandet?)! Then many products which were supposed to be deleted, are not deleted any more due the completeness >= 0.3

Any advise?

This process is important (test => tag => review => remove) because we could use it to allow more mass modifications.
It allows reviewers to confirm that a mass modification is ok, before it happens.