Skip to content

feat: support csv in fga tuple delete #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 21, 2025
Merged

Conversation

bensooraj
Copy link
Contributor

@bensooraj bensooraj commented Apr 4, 2025

Description

  • fga tuple delete --file=(*.json|*.yaml|*csv)
  • The tuple delete command now supports reading values of a *.csv file as well

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

* `fga tuple delete --file=(*.yaml|*csv)`
* The tuple delete command now supports reading values of a csv file as well
@bensooraj bensooraj requested a review from a team as a code owner April 4, 2025 12:12
@Siddhant-K-code
Copy link
Member

Siddhant-K-code commented Apr 5, 2025

👋🏻 @bensooraj, I saw you ticked I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev) [Provide a link to any relevant PRs in the references section above]"

Could you link the docs PR too? As, it would be super helpful if we can have docs change too along with the product side change. Let me know, if you need any help with that.

For context: We have our docs here

Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! The changes improve code organization and add solid test coverage. A few minor suggestions for future improvements (suggested below)

These are minor suggestions - the PR is solid and ready to merge as is. Thanks for the improvements!

@bensooraj bensooraj marked this pull request as draft April 5, 2025 20:06
bensooraj added a commit to bensooraj/openfga.dev that referenced this pull request Apr 6, 2025
@bensooraj
Copy link
Contributor Author

👋🏻 @bensooraj, I saw you ticked I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev) [Provide a link to any relevant PRs in the references section above]"

Could you link the docs PR too? As, it would be super helpful if we can have docs change too along with the product side change. Let me know, if you need any help with that.

For context: We have our docs here

I have added documentation at openfga.dev#1004

@bensooraj bensooraj marked this pull request as ready for review April 6, 2025 09:59
@Siddhant-K-code
Copy link
Member

@bensooraj can you please fix the lint errs

@bensooraj
Copy link
Contributor Author

@bensooraj can you please fix the lint errs

I thought I did, my bad. I have fixed those as well.

Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

Will also someone from @openfga/dx team for a final review & then we can merge

@dyeam0
Copy link
Member

dyeam0 commented Apr 7, 2025

@bensooraj Thanks for the contribution and, @Siddhant-K-code, thanks for the review!

We will assign someone in our planning meeting this week to pick this one up for a final review.

@dyeam0
Copy link
Member

dyeam0 commented Apr 9, 2025

Hi @bensooraj, we discussed this PR during our planning meeting. We've put it in the queue for someone to pick up. They will have a full review for you next week. Thanks!

@dyeam0 dyeam0 added the enhancement New feature or request label Apr 9, 2025
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bensooraj for the contribution and @Siddhant-K-code for the help reviewing!

@rhamzeh rhamzeh added this pull request to the merge queue Apr 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 21, 2025
@rhamzeh
Copy link
Member

rhamzeh commented Apr 21, 2025

Needs #489 to be merged first so that the lint issues pass, then we can merge this

@rhamzeh rhamzeh enabled auto-merge April 21, 2025 11:37
@rhamzeh rhamzeh added this pull request to the merge queue Apr 21, 2025
Merged via the queue into openfga:main with commit b5008aa Apr 21, 2025
16 checks passed
@bensooraj bensooraj deleted the openfgacli-477 branch April 21, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants