-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support csv in fga tuple delete
#478
base: main
Are you sure you want to change the base?
Conversation
* `fga tuple delete --file=(*.yaml|*csv)` * The tuple delete command now supports reading values of a csv file as well
👋🏻 @bensooraj, I saw you ticked Could you link the docs PR too? As, it would be super helpful if we can have docs change too along with the product side change. Let me know, if you need any help with that. For context: We have our docs here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! The changes improve code organization and add solid test coverage. A few minor suggestions for future improvements (suggested below)
These are minor suggestions - the PR is solid and ready to merge as is. Thanks for the improvements!
I have added documentation at openfga.dev#1004 |
@bensooraj can you please fix the lint errs |
…openfga/openfga/pkg/tuple/tuple.go`
I thought I did, my bad. I have fixed those as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
Will also someone from @openfga/dx team for a final review & then we can merge
@bensooraj Thanks for the contribution and, @Siddhant-K-code, thanks for the review! We will assign someone in our planning meeting this week to pick this one up for a final review. |
Description
fga tuple delete --file=(*.json|*.yaml|*csv)
*.csv
file as wellReferences
Review Checklist
main