Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: fix classic node template description #315

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

jswhisperer
Copy link
Contributor

change typo from Go to node

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

derek bot commented Jan 19, 2025

Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide.

### :bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

change typo from Go to node

Signed-off-by: Gregory The JSWhisperer <[email protected]>
@alexellis
Copy link
Member

Thanks for the PR.

Out of interest.. how did you end up using the old node template?

@alexellis alexellis merged commit a14e834 into openfaas:master Jan 20, 2025
@jswhisperer jswhisperer deleted the patch-1 branch January 21, 2025 23:08
@jswhisperer
Copy link
Contributor Author

Hey @alexellis I was just reading through the docs again to get started. We used to follow and interact quite a bit on twitter I was @cactusdove now I'm @jswhisperer on socials. I wanted to see how the projects going, the docs are good but a little all over the place with some outdated ones, if you wanted someone to amalgamate them I've free.

@jswhisperer
Copy link
Contributor Author

I think it was this tutorial on blog, which was the first nodejs one I found https://www.openfaas.com/blog/develop-functions-locally/

@alexellis
Copy link
Member

Thanks, this context is always appreciated and should be absolutely included in any issues or PRs.

That specific blog post uses node18 not node.

node is a deprecated template that we've kept around for people.

@alexellis
Copy link
Member

Thanks for the offer, if you have a list of articles you'd like to re-test or update, please feel free.

It's a minor and unimportant change, but the node18 reference could be updated to a newer template. Readers could probably also guess / do this intuitively, but we could go back and update older posts if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants