Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pip cache in docker build #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

santuari
Copy link

@santuari santuari commented Apr 26, 2021

Description

The pip cache is created during the Docker build and it might occupy around 50MB. The cache is not needed for running the application.

Motivation and Context

Reduce the size of the Docker image

How Has This Been Tested?

I tested by pushing the same function with and without the cache. I also expect that this cannot impact the function behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Apr 26, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Apr 26, 2021
@santuari santuari force-pushed the reduce-docker-size branch from 9f9f76f to ae9f436 Compare April 26, 2021 14:40
@derek derek bot removed the no-dco label Apr 26, 2021
Signed-off-by: Michele Santuari <[email protected]>
@santuari santuari force-pushed the reduce-docker-size branch from ae9f436 to 461aaf0 Compare April 26, 2021 14:45
@santuari
Copy link
Author

Hi all,

I have created this PR that it is very simple. and I guess that no tests are needed. Should I do something more?

Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and makes a ton of sense

@alexellis 🚀

@santuari
Copy link
Author

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants