Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm chart for the RabbitMQ connector #1230

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

welteki
Copy link
Member

@welteki welteki commented Dec 2, 2024

Description

Add a new Helm chart for the RabbitMQ connector.

Why is this needed?

  • I have raised an issue to propose this change (required)

Allow users to deploy the OpenFaaS rabbitmq-connector with Helm.

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

Deployed the connector in my local cluster using the chart.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexellis
Copy link
Member

@welteki could you add a securityContext that is read from the chart?

The other connectors may not have this yet, but will do in time.

@welteki welteki force-pushed the rabbitmq-connector branch from e9ace75 to 88c1937 Compare December 2, 2024 15:53
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
@welteki welteki force-pushed the rabbitmq-connector branch from 88c1937 to f1051ae Compare December 2, 2024 16:09
@alexellis alexellis merged commit 2cf6886 into openfaas:master Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants