Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote ingress records from chart into ingress template #1213

Merged
merged 1 commit into from
May 28, 2024

Conversation

alexellis
Copy link
Member

Description

Quote ingress records from chart into ingress template

Why is this needed?

The previous template was too closely tied to the beta version of ingress to work with the new format and layout of ingress v1.

Instead of trying to remap values from custom fields in the values.yaml file, this version quotes the text directly meaning it works better for the newer format.

Who is this for?

New users of OpenFaaS on Kubernetes.

How Has This Been Tested?

Tested e2e with a KinD cluster and inlets.

alex@bq:~$ kubectl get issuer -n openfaas
NAME                  READY   AGE
letsencrypt-prod      True    4m32s
letsencrypt-staging   True    4m32s
alex@bq:~$ kubectl get ingress -n openfaas
NAME               CLASS   HOSTS                            ADDRESS          PORTS     AGE
openfaas-ingress   nginx   gw.d.o6s.io,dashboard.d.o6s.io   134.209.188.10   80, 443   6m54s
alex@bq:~$ kubectl get svc -n default
NAME                                 TYPE           CLUSTER-IP      EXTERNAL-IP                     PORT(S)                      AGE
ingress-nginx-controller             LoadBalancer   10.96.205.130   134.209.188.10,134.209.188.10   80:32019/TCP,443:32205/TCP   27m
ingress-nginx-controller-admission   ClusterIP      10.96.188.19    <none>                          443/TCP                      27m
kubernetes                           ClusterIP      10.96.0.1       <none>                          443/TCP                      30m
alex@bq:~$ 
alex@bq:~$ curl -i https://gw.d.o6s.io
HTTP/2 403 
date: Tue, 28 May 2024 09:26:54 GMT
content-length: 0
strict-transport-security: max-age=31536000; includeSubDomains

alex@bq:~$ curl -i https://dashboard.d.o6s.io
HTTP/2 200 
date: Tue, 28 May 2024 09:26:57 GMT
content-type: text/html
strict-transport-security: max-age=31536000; includeSubDomains

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

For some people this may be a breaking change

The previous template was too closely tied to the beta version
of ingress to work with the new format and layout of ingress v1.

Instead of trying to remap values from custom fields in the
values.yaml file, this version quotes the text directly meaning
it works better for the newer format.

Tested e2e with a KinD cluster and inlets.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
@alexellis alexellis requested a review from welteki May 28, 2024 09:27
@alexellis alexellis merged commit 7ffa78b into master May 28, 2024
7 checks passed
@alexellis alexellis deleted the quote_ingress branch May 28, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant