Quote ingress records from chart into ingress template #1213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quote ingress records from chart into ingress template
Why is this needed?
The previous template was too closely tied to the beta version of ingress to work with the new format and layout of ingress v1.
Instead of trying to remap values from custom fields in the values.yaml file, this version quotes the text directly meaning it works better for the newer format.
Who is this for?
New users of OpenFaaS on Kubernetes.
How Has This Been Tested?
Tested e2e with a KinD cluster and inlets.
Types of changes
For some people this may be a breaking change