Revert helm annotation on CRDs

It seems like this approach will not work without setting
other metadata for helm.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

artifacts/crds/crds.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: jwtissuers.iam.openfaas.com
@@ -87,7 +86,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: policies.iam.openfaas.com
@@ -185,7 +183,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: roles.iam.openfaas.com
@@ -274,7 +271,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.13.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: functioningresses.openfaas.com
@@ -439,7 +435,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: functions.openfaas.com
@@ -636,7 +631,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: profiles.openfaas.com

artifacts/crds/iam.openfaas.com_jwtissuers.yaml

@@ -3,7 +3,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: jwtissuers.iam.openfaas.com

artifacts/crds/iam.openfaas.com_policies.yaml

@@ -3,7 +3,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: policies.iam.openfaas.com

artifacts/crds/iam.openfaas.com_roles.yaml

@@ -3,7 +3,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: roles.iam.openfaas.com

artifacts/crds/openfaas.com_functioningresses.yaml

@@ -3,7 +3,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.13.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: functioningresses.openfaas.com

artifacts/crds/openfaas.com_functions.yaml

@@ -3,7 +3,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: functions.openfaas.com

artifacts/crds/openfaas.com_profiles.yaml

@@ -3,7 +3,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   labels:
     app.kubernetes.io/name: openfaas
   name: profiles.openfaas.com

chart/openfaas/templates/iam.openfaas.com_jwtissuers-crd.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   name: jwtissuers.iam.openfaas.com
 spec:
   group: iam.openfaas.com

chart/openfaas/templates/iam.openfaas.com_policies-crd.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   name: policies.iam.openfaas.com
 spec:
   group: iam.openfaas.com

chart/openfaas/templates/iam.openfaas.com_roles-crd.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   name: roles.iam.openfaas.com
 spec:
   group: iam.openfaas.com

chart/openfaas/templates/openfaas.com_functioningresses-crd.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.13.0
-    helm.sh/resource-policy: keep
   name: functioningresses.openfaas.com
 spec:
   group: openfaas.com

chart/openfaas/templates/openfaas.com_functions-crd.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   name: functions.openfaas.com
 spec:
   group: openfaas.com

chart/openfaas/templates/openfaas.com_profiles-crd.yaml

@@ -5,7 +5,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
-    helm.sh/resource-policy: keep
   name: profiles.openfaas.com
 spec:
   group: openfaas.com

hack/update-crds.sh

@@ -22,8 +22,9 @@ for f in ./artifacts/crds/*.yaml; do \
   echo "Annotating & labelling: $f"
   tmp_file=$(mktemp)
 
-  kubectl annotate --overwrite -f $f --local=true -o yaml helm.sh/resource-policy=keep > tmp_file
-  mv tmp_file $f
+  # AE: This doesn't work without additional labels such as meta.helm.sh/release-name and app.kubernetes.io/managed-by
+  # kubectl annotate --overwrite -f $f --local=true -o yaml helm.sh/resource-policy=keep > tmp_file
+  # mv tmp_file $f
 
   kubectl label --overwrite -f $f --local=true -o yaml app.kubernetes.io/name=openfaas > tmp_file
   mv tmp_file $f