Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the port of the keepalived process is now configurable #355

Merged
merged 2 commits into from
Dec 27, 2023
Merged

the port of the keepalived process is now configurable #355

merged 2 commits into from
Dec 27, 2023

Conversation

EmielBruijntjes
Copy link
Contributor

Description

I just reported issue #354. I checked the code, and this might be a possible implementation.

@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2023
@renyunkang
Copy link
Member

Thank you for your contribution. Please proceed to complete the following:

  1. Squash your commits.
  2. Check DCO. https://github.com/openelb/openelb/pull/355/checks?check_run_id=16431242313

renyunkang and others added 2 commits September 4, 2023 10:57
@renyunkang @EmielBruijntjes
fix: sync vip configmap
ad552c2 
Signed-off-by: renyunkang <[email protected]>
Signed-off-by: Emiel Bruijntjes <[email protected]>
@EmielBruijntjes
the port of the keepalived process is now configurable
6e7e59d 
Signed-off-by: Emiel Bruijntjes <[email protected]>
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2023
@renyunkang
Copy link
Member

Can you handle the commit information again so that I can only see the information you modified?

@renyunkang
Copy link
Member

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ac1ca73efaf986b011facd0931b3443a6e6feba1

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ac1ca73efaf986b011facd0931b3443a6e6feba1

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmielBruijntjes, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmielBruijntjes, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 48334f6 into openelb:master Dec 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@renyunkang renyunkang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmielBruijntjes @renyunkang @ks-ci-bot