-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confidence interval text + histogram table #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI and layout look good for this PR. One general comment is that the code for generating the table is not included as a code snippet in the analysis tab. I realize that code is more complicated, but the user might be looking for it. Maybe that is something we can find out when we get feedback from other users.
You mean the fake, normally distributed data? That's true, but I would think that would be a distraction: In the notebook, the real data is being read, so there's no need for this fake data. But if we hear something different from users, could consider it. |
Ok, I just thought it would help the users see how the histogram that is based on the fake data is being generated, since it's the same process that will be used on the real data. We can see what the users think 👍 |
Think I understand now. You're right,
Two TODOs:
|
Previously, the generation of the fake data and rendering were in the same function. This pulls the generation of fake data into a separate reactive calc that gets called from several different functions.
For the reviewer: