Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confidence interval text + histogram table #211

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Jan 7, 2025

Previously, the generation of the fake data and rendering were in the same function. This pulls the generation of fake data into a separate reactive calc that gets called from several different functions.

For the reviewer:

  • Are the UI and layout reasonable?
  • The app is getting more complicated, but none of the complexity really has anything to do with DP. Is this codebase going to be maintainable by people other than Chuck?

@mccalluc mccalluc marked this pull request as ready for review January 7, 2025 23:43
@ekraffmiller ekraffmiller self-assigned this Jan 8, 2025
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI and layout look good for this PR. One general comment is that the code for generating the table is not included as a code snippet in the analysis tab. I realize that code is more complicated, but the user might be looking for it. Maybe that is something we can find out when we get feedback from other users.

@ekraffmiller ekraffmiller removed their assignment Jan 8, 2025
@mccalluc
Copy link
Contributor Author

mccalluc commented Jan 8, 2025

code for generating the table is not included as a code snippet in the analysis tab

You mean the fake, normally distributed data? That's true, but I would think that would be a distraction: In the notebook, the real data is being read, so there's no need for this fake data. But if we hear something different from users, could consider it.

@mccalluc mccalluc merged commit bb0e6a2 into main Jan 8, 2025
2 checks passed
@mccalluc mccalluc deleted the 203-confidence-interval-in-plot branch January 8, 2025 19:18
@ekraffmiller
Copy link
Member

code for generating the table is not included as a code snippet in the analysis tab

You mean the fake, normally distributed data? That's true, but I would think that would be a distraction: In the notebook, the real data is being read, so there's no need for this fake data. But if we hear something different from users, could consider it.

Ok, I just thought it would help the users see how the histogram that is based on the fake data is being generated, since it's the same process that will be used on the real data. We can see what the users think 👍

@mccalluc
Copy link
Contributor Author

mccalluc commented Jan 9, 2025

see how the histogram that is based on the fake data is being generated

Think I understand now. You're right, dp.Context.compositor is used in two separate places:

  • dp_helper.py (used by the Shiny UI)
  • _context.py (template used to generate notebook)

Two TODOs:

  • eventually combine these, so we know they are in sync
  • Also: use _context.py to make a code snip for the user (although that is the entire computation, and maybe we just want to look at one stat at a time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
2 participants