Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright test for --demo #120

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Playwright test for --demo #120

merged 5 commits into from
Nov 4, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 1, 2024

Initially tried to use mocking for this, but couldn't get it to work.

... but in the end, I think this is a pretty clear approach.

When we handle this:

expand the test.

@mccalluc mccalluc requested a review from ekraffmiller November 1, 2024 15:38
@mccalluc mccalluc marked this pull request as ready for review November 1, 2024 15:38
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the problem is that you referred to about using mocks, but this seems to work well to test the app being run with and without the demo data. Approving

@mccalluc mccalluc merged commit 02ef2ad into main Nov 4, 2024
2 checks passed
@mccalluc mccalluc deleted the 105-playwright-for-demo branch November 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Playwright test for --demo
2 participants