Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handing for --demo #103

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Better handing for --demo #103

merged 10 commits into from
Nov 1, 2024

Conversation

mccalluc
Copy link
Contributor

Does not address:

Eventually, we want the inputs on this screen to be frozen if they have been set from the CLI.

@mccalluc mccalluc requested a review from ekraffmiller October 30, 2024 02:17
@ekraffmiller
Copy link
Member

Looks good! UI Suggestion: When running with --demo, don't show the FileUpload component, since demo.csv is being used. Include some text about demo being used instead.

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a follow up suggestion for UI

@mccalluc
Copy link
Contributor Author

@mccalluc
Copy link
Contributor Author

App test fails:

        # -- Download results --
        page.get_by_role("button", name="Download results").click()
        expect_not_visible(pick_dataset_text)
>       expect_not_visible(perform_analysis_text)

Looking at the trace, it looks like it might have gotten bogged down in recalculating the graphs and didn't respond to the mouseclick to move to the next page quickly enough. Is there a risk of the application being unresponsive?

For now, just try to run run the tests.

@mccalluc
Copy link
Contributor Author

mccalluc commented Nov 1, 2024

@mccalluc mccalluc merged commit 2994c7b into main Nov 1, 2024
2 checks passed
@mccalluc mccalluc deleted the 81-75-better-demo branch November 1, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Handle --demo nicely on first tab More explanation in UI when running with --demo
2 participants