-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handing for --demo
#103
Conversation
Looks good! UI Suggestion: When running with --demo, don't show the FileUpload component, since demo.csv is being used. Include some text about demo being used instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a follow up suggestion for UI
App test fails:
Looking at the trace, it looks like it might have gotten bogged down in recalculating the graphs and didn't respond to the mouseclick to move to the next page quickly enough. Is there a risk of the application being unresponsive? For now, just try to run run the tests. |
--demo
nicely on first tab #81: We can't actually set the value of the upload widget, but we can set placeholder text.--demo
#75: Add tool tips on the first tab if we're running with--demo
Does not address:
Eventually, we want the inputs on this screen to be frozen if they have been set from the CLI.