Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added video/3gpp filetype #220

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

Added video/3gpp filetype #220

wants to merge 38 commits into from

Conversation

apmuthu
Copy link

@apmuthu apmuthu commented Sep 15, 2015

DB Schema & SQL cleanup, fixes

@stephenlawrence
Copy link
Member

I better way to handle this type of merge is to create individual issues on the opendocman page and then create individual pull requests for each.

@apmuthu
Copy link
Author

apmuthu commented Oct 7, 2015

@stephenlawrence: Thanks for the comments. I can create separate issues for these changes, but how does the separate pull request work? When I make a pull request, all future changes also get added in till the issue is merged or rejected!

@apmuthu
Copy link
Author

apmuthu commented Oct 7, 2015

The install/odm.php is uptodate with the database.sql.

Synched database.sql with install/odm.php
Arranged the tables in alphabetical order in database.sql to match dumps
opendocman#220 (comment)
Cleaned up all language files and synced them with english file
All language files are now in same string order
@stephenlawrence
Copy link
Member

I believe you would create a branch and odm issue for each of these changes and create a pull request from that branch into odm master.

@apmuthu
Copy link
Author

apmuthu commented Oct 8, 2015

Have completed all SQL changes, Upgrades, Language cleanups, ERD updations, Categories in File List display. Updated the SQL changes in the comment above as well.

Next time I will make separate unit pull requests. Not proficient with Git branching and merging several tracks as yet.

You can now pull it all in. Just did a successful dry run.

@stephenlawrence
Copy link
Member

While I appreciate the efforts here this is not a good way of submitting code. I cannot merge in a large list of different issues, I need to be able to accept or reject individual changes and make comments on them. Some of them will not be included, some need changes applied, etc.. I have created new Issues for some of your changes which you can create branches for.

@stephenlawrence stephenlawrence marked this pull request as draft January 9, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants