Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t duplicated datasets with a harvest.remote_id URI when harvesting #3219

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don’t duplicated datasets with a harvest.remote_id URI when harvesting #3219

wants to merge 3 commits into from

Conversation

magopian
Copy link
Contributor

@magopian magopian commented Dec 5, 2024

Fixes #1587

@magopian magopian force-pushed the dont-duplicate-harvested-datasets-with-URIs branch from a756a3c to 579cddb Compare December 5, 2024 11:21
bolinocroustibat
bolinocroustibat approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@bolinocroustibat bolinocroustibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like it makes the code more robust. Always painful to implement a test, except maybe when it is to test a very new feature :)

docs/harvesting.md Outdated Show resolved Hide resolved
maudetes
maudetes approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
And thank you for adding tests, it's not always easy with harvesting.
I have minor comments only

Don't forget the changelog ;)

docs/harvesting.md Show resolved Hide resolved
udata/harvest/tests/test_base_backend.py Outdated Show resolved Hide resolved
udata/harvest/tests/test_base_backend.py Outdated Show resolved Hide resolved
udata/harvest/tests/test_base_backend.py Outdated Show resolved Hide resolved
udata/harvest/tests/test_base_backend.py Outdated Show resolved Hide resolved
@magopian magopian force-pushed the dont-duplicate-harvested-datasets-with-URIs branch from 579cddb to aec0a6a Compare December 10, 2024 13:52
@magopian magopian force-pushed the dont-duplicate-harvested-datasets-with-URIs branch from aec0a6a to 7af95a0 Compare December 10, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

@bolinocroustibat bolinocroustibat bolinocroustibat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eviter de créer un doublon lors du moissonnage si le remote ID est une URI et existe déjà
3 participants
@magopian @bolinocroustibat @maudetes