Temporal coverage with only start date #3192
Conversation
Code from @ThibaudDauce: https://github.com/opendatateam/udata/compare/temporal_coverage_with_only_start_date?expand=1 Was copy/pasted from his branch, because cherry-picking led to humongous conflicts for some reason...
There was a problem hiding this comment.
Thank you for this PR! I think it works nicely but we should probably check for side effects a bit 🕵️
On udata-front, we should probably re-open datagouv/udata-front#411 and I think the udata (old) admin daterange may crash as well?
Don't forget the changelog ;)
magopian
changed the title
Regarding the (old) admin daterange, I've just tested and it seems to work as usual, no crashes if you provide both start and end date (this behavior wasn't changed by this PR as far as I can tell). Not providing an end date shows a frontend validation error asking for both the start and end date. One thing that fails in the old admin: editing a dataset that has no end date. In this case, the dataset can't be updated unless an end date is provided. I'll work on allowing that in this PR. |
|
Updated the PR with a change to the old admin so it also allows setting/editing a temporal coverage with only a start date. |
Signed-off-by: Mathieu Agopian <[email protected]>
There was a problem hiding this comment.
We'll need to be ready to merge datagouv/udata-front#411 before merging this PR.
I think we will probably need to update the front-end as well. cc @nicolaskempf57 & @ThibaudDauce
Fixes #1268
Code from @ThibaudDauce:
https://github.com/opendatateam/udata/compare/temporal_coverage_with_only_start_date?expand=1
Was copy/pasted from his branch, because cherry-picking led to humongous conflicts for some reason...