Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Udpate purge tasks #3167

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Udpate purge tasks #3167

merged 6 commits into from
Dec 19, 2024

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Oct 8, 2024 •
edited
Loading

  • Remove dataservice link a to a dataset when purging dataset
  • Remove harvest items related to a dataservice when purging it

@maudetes maudetes marked this pull request as draft October 8, 2024 12:31
@maudetes maudetes marked this pull request as ready for review December 18, 2024 18:58
@maudetes maudetes requested a review from magopian December 18, 2024 18:58
magopian
magopian approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@magopian magopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, nice!
Thanks also for taking the opportunity to add the missing assertions in test_dataset_tasks 🙏

🚢

@maudetes maudetes merged commit b33b9c0 into opendatateam:master Dec 19, 2024
1 check passed
@maudetes maudetes deleted the chore/udpate-purge-tasks branch December 19, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magopian magopian magopian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maudetes @magopian