feat: Display multilingual relation labels #344
Conversation
Also, make the values in the 'label' dict singular, so we can use them to label each relation ('Relation 1', 'Relation 2'...). This will make the form less confusing now we have texts in all for languages for the relations, going from two fields to five per relation.
bellisk
force-pushed
the
feat/allow-multilingual-relations
branch
from
d37da2f to
b7826c7
Compare
bellisk
force-pushed
the
feat/allow-multilingual-relations
branch
from
b7826c7 to
091bca0
Compare
| """ | ||
| relations = _get_relations_from_storage(data) | ||
| if not relations: | ||
| relations = get_relations_from_form(data) | ||
|
|
||
| data_empty = {'title': '', 'url': ''} |
There was a problem hiding this comment.
We were using three different terms for the text of a relation in various places in the code (label, title, text) and it was a mess. I'm eliminating title to simplify things a bit.
| @@ -2,13 +2,13 @@ | |||
| {% set publisher = h.ogdch_publisher_form_helper(data) %} | |||
|
|
|||
| {# Input for publisher names in multiple languages #} | |||
| {% for lang in ['fr', 'de', 'it', 'en'] %} | |||
| {% for lang in h.fluent_form_languages(field, entity_type, object_type, schema) %} | |||
There was a problem hiding this comment.
Making the order of languages the same as in the other multilingual form snippets.
| label=lang.upper() ~ ' ' + h.scheming_language_text(field.label_name), | ||
| placeholder=lang.upper() ~ ' ' + h.scheming_language_text(field.form_placeholder_name), |
There was a problem hiding this comment.
Making the multilingual labels and placeholders consistent with the other multilingual form snippets.
| @@ -2,19 +2,24 @@ | |||
|
|
|||
| {% set relations_rows = h.ogdch_relations_form_helper(data) %} | |||
| {%- for row in relations_rows -%} | |||
| <h4 class="relation-label {{row.css_class}}">{{h.scheming_language_text(field.label) ~ ' ' ~ row.index}}</h4> | |||
There was a problem hiding this comment.
I added a header for each relation in the form, just "Relation 1," "Relation 2," etc., because the form looks very cluttered now that there are five text-inputs per relation. :( Not sure how to improve this without spending a lot of extra time on it.
| firstHiddenRows.addClass('ogdch-show-row'); | ||
| var firstHiddenLabel = $('.relation-label.ogdch-hide-row') | ||
| .slice(0, 1); | ||
| firstHiddenLabel.addClass('ogdch-show-row') |
There was a problem hiding this comment.
firstHiddenLabel.addClass('ogdch-show-row');
; - should be added
| """ | ||
| relations = _get_relations_from_storage(data) | ||
| if not relations: | ||
| relations = get_relations_from_form(data) | ||
|
|
||
| data_empty = {'title': '', 'url': ''} |
| """ | ||
| relations = _get_relations_from_storage(data) | ||
| if not relations: | ||
| relations = get_relations_from_form(data) | ||
|
|
||
| data_empty = {'title': '', 'url': ''} |
| @@ -2,19 +2,24 @@ | |||
|
|
|||
| {% set relations_rows = h.ogdch_relations_form_helper(data) %} | |||
| {%- for row in relations_rows -%} | |||
| <h4 class="relation-label {{row.css_class}}">{{h.scheming_language_text(field.label) ~ ' ' ~ row.index}}</h4> | |||
No description provided.