fix: correct NMSBoxes input format in license_plate_detection_yunet - #314
Open
princemittalr wants to merge 1 commit into
Open
fix: correct NMSBoxes input format in license_plate_detection_yunet#314princemittalr wants to merge 1 commit into
princemittalr wants to merge 1 commit into
Conversation
NMSBoxes expects [x, y, w, h] but code was passing [x1, y1, x2, y2] corner coordinates, breaking IoU computation in multi-plate scenes. Fix: compute axis-aligned bounding box from 4 corner points and convert to [x, y, w, h] format. Also flatten keepIdx to handle NMSBoxes return type change between OpenCV 4.5 and 4.7+. Fixes opencv#275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #275
Problem
NMSBoxesexpects bounding boxes in[x, y, width, height]format, but_postprocesswas passingdets[:, 0:4]which contains[x1, y1, x2, y2]— the first two corner coordinates. This breaks IoU computation completely
in multi-plate scenes, causing wrong boxes to be suppressed.
Fix
[x, y, w, h]format forNMSBoxeskeepIdxto handle return type difference between OpenCV 4.5 and 4.7+Changes
models/license_plate_detection_yunet/lpd_yunet.py