Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cpp demo for wechatqrcode #279

Merged
merged 4 commits into from
Dec 13, 2024
Merged

feat: add cpp demo for wechatqrcode #279

merged 4 commits into from
Dec 13, 2024

Conversation

souhhmm
Copy link
Contributor

@souhhmm souhhmm commented Dec 1, 2024 •
edited
Loading

Added a C++ demo for WeChatQRCode as per #135.
Files added/changed: demo.cpp, CMakeLists.txt and README.md.
Edit: Following the convention, I've refactored the code to be class based.

Demonstration

Build:

image

Using camera input:

image

Using an image:

image

fengyuentau
fengyuentau reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍 Please take a look at my comments below.

models/qrcode_wechatqrcode/demo.cpp Outdated Show resolved Hide resolved
models/qrcode_wechatqrcode/demo.cpp Outdated Show resolved Hide resolved
@fengyuentau fengyuentau mentioned this pull request Dec 2, 2024
Open
@fengyuentau fengyuentau self-assigned this Dec 2, 2024
@fengyuentau fengyuentau added the demo anything related to demo in Python / C++ label Dec 2, 2024
@souhhmm
Copy link
Contributor Author

souhhmm commented Dec 2, 2024

Hey, thanks for the feedback, I have updated the code.

@souhhmm souhhmm requested a review from fengyuentau December 2, 2024 17:14
fengyuentau
fengyuentau reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried your demo locally on my host. It works great! Thank you👍

Before we merge this PR, could you add an extra information as below?

models/qrcode_wechatqrcode/README.md Outdated Show resolved Hide resolved
@souhhmm souhhmm requested a review from fengyuentau December 13, 2024 12:19
fengyuentau
fengyuentau approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fengyuentau fengyuentau merged commit a988f33 into opencv:main Dec 13, 2024
@souhhmm souhhmm deleted the feat/qr-cpp-demo branch December 14, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengyuentau fengyuentau fengyuentau approved these changes

Assignees

@fengyuentau fengyuentau

Labels
demo anything related to demo in Python / C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souhhmm @fengyuentau