Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenCV version assertions in ViTTrack & RAFT and text offset #234

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ryan1288
Copy link
Contributor

@ryan1288 ryan1288 commented Feb 26, 2024

This PR addresses compatibility issues with OpenCV version 4.9.0 by updating assertions in the code. Issue was pointed out in #135 (comment).

Additionally, a minor adjustment has been made to increase the offset, preventing the confidence text from overlapping with the bounding box border.
image

@fengyuentau fengyuentau self-requested a review February 27, 2024 06:44
@fengyuentau fengyuentau self-assigned this Feb 27, 2024
@fengyuentau fengyuentau added bug Something isn't working demo anything related to demo in Python / C++ labels Feb 27, 2024
@fengyuentau fengyuentau added this to the 4.10.0 milestone Feb 27, 2024
Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍

@fengyuentau fengyuentau merged commit b1322ea into opencv:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working demo anything related to demo in Python / C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants