tarGenerator.AddFile: ignore llistxattr eopnotsupp #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 73.48% 73.45% -0.04%
==========================================
Files 60 60
Lines 4884 4886 +2
==========================================
Hits 3589 3589
- Misses 935 937 +2
Partials 360 360
|
smoser
approved these changes
Oct 10, 2023
|
@cyphar not sure why I had it in draft mode until monday - it is ready for review. |
|
@tych0 ping |
tych0
reviewed
Oct 18, 2023
If it's not supported, just assume there are no xattrs, don't fail the addfile. Changelog: 10/18: use errors.Cause as suggested by Tycho Signed-off-by: Serge Hallyn <[email protected]>
hallyn
force-pushed
the
2023-10-04/marlstat
branch
from
38739d3
to
685e414
Compare
tych0
approved these changes
Oct 19, 2023
|
FWIW, LGTM. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's not supported, just assume there are no xattrs, don't fail the addfile.