Do not chmod +r if we don't need to #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 73.48% 73.48%
=======================================
Files 60 60
Lines 4884 4884
=======================================
Hits 3589 3589
Misses 935 935
Partials 360 360
|
|
I've just fixed the CI failure in main -- can you rebase? |
If the inode is a mountpoint, chmod may just fail. (See project-stacker/stacker#450) Signed-off-by: Serge Hallyn <[email protected]>
|
Thanks, success :) |
smoser
added a commit
to smoser/stacker
that referenced
this pull request
Sep 26, 2023
Serge's change for avoiding chmod +r if not necessary was merged upstream under opencontainers/umoci#499. We do not need to use the project-stacker fork any more. Dropping that and updating to current umoci main looks like this: go mod get github.com/opencontainers/umoci@main go mod edit -dropreplace github.com/opencontainers/umoci go mod tidy Signed-off-by: Scott Moser <[email protected]>
smoser
added a commit
to smoser/stacker
that referenced
this pull request
Sep 26, 2023
Serge's change for avoiding chmod +r if not necessary was merged upstream under opencontainers/umoci#499. We do not need to use the project-stacker fork any more. Dropping that and updating to current umoci main looks like this: go mod get github.com/opencontainers/umoci@main go mod edit -dropreplace github.com/opencontainers/umoci go mod tidy Signed-off-by: Scott Moser <[email protected]>
rchincha
pushed a commit
to project-stacker/stacker
that referenced
this pull request
Sep 27, 2023
Serge's change for avoiding chmod +r if not necessary was merged upstream under opencontainers/umoci#499. We do not need to use the project-stacker fork any more. Dropping that and updating to current umoci main looks like this: go mod get github.com/opencontainers/umoci@main go mod edit -dropreplace github.com/opencontainers/umoci go mod tidy Signed-off-by: Scott Moser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the inode is a mountpoint, chmod may just fail.
(See project-stacker/stacker#450)