Clarify what "ignore" means for a registry #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
brendandburns,
jonjohnsonjr,
jstarks,
jonboulle,
stevvooe,
vbatts and
cyphar
as code owners
👀 (both in the commit message and the title) |
Signed-off-by: Brandon Mitchell <[email protected]>
sudo-bmitch
force-pushed
the
pr-extensibility
branch
from
2aafb5a
to
b5cecc9
Compare
sudo-bmitch
changed the title
|
Pinging @opencontainers/image-spec-maintainers since this question is getting asked again. |
sajayantony
reviewed
Dec 1, 2022
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| Implementations that are reading/processing [manifests](manifest.md) or [image indexes](image-index.md) MUST NOT generate an error if they encounter an unknown property. | |||
| Instead they MUST ignore unknown properties. | |||
| Implementations that are storing/returning manifests and blobs in a content addressable store SHALL NOT modify that content, even when encountering unknown properties. | |||
There was a problem hiding this comment.
Is there any reason this is not a MUST?
--update
This comment it moot -
SHALL NOT is equivalent to must as per - https://www.rfc-editor.org/rfc/rfc2119
in https://github.com/opencontainers/image-spec/blob/4df8887994e871a59f9e30e8dd811d060f6a39ef/spec.md
|
Closing this this has been resolved in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Mitchell [email protected]
In various discussions the question has been raised if "ignore unknown properties" means the fields should be removed by a registry server. This clarifies that a registry shall not modify data being stored/returned in a content addressable store.