Spatial slice select update #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think all OK here - perhaps would benefit with the next mob programming session |
|
@felix-e-h-p this looks really good! There are just a few little things I think we should tighten up on |
dfulu
requested changes
Apr 7, 2025
dfulu
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main refactor aspects are as follows:
CoordinateConverter Class - introduced to encapsulate coordinate transformations.
Combined Pixel Index Function - two pixel-index functions merged into one, using the CoordinateConverter class to handle different coordinate systems.
Improved Padding Logic - pre-existing padding logic simplified by calculating quantities explicitly.
New test added to cover cases with allow_partial_slice=False (not sure if truly necessary).