[Repo Assist] eng(build): enforce TreatWarningsAsErrors across all source projects

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary (Task 4 — Engineering Investments)

Adds <TreatWarningsAsErrors>true</TreatWarningsAsErrors> to src/Directory.Build.props so compiler warnings in source code are treated as build errors rather than accumulating silently over time.

Why

The tests/Directory.Build.props already enforces TreatWarningsAsErrors for all test projects. This PR extends the same discipline to production source code under src/. Warnings that slip through today tend to become noise that gets ignored, and noise is how subtle bugs enter the codebase.

What changed

File	Change
src/Directory.Build.props	Added <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
src/OpenClaw.Shared/OpenClaw.Shared.csproj	Added <NoWarn>$(NoWarn);CS8524</NoWarn>

The CS8524 suppression

ExecApprovalsCoordinator.cs line 148 contains an intentional non-exhaustive switch expression (no _ arm) so the compiler warns when a new ExecApprovalPromptOutcome enum value is added without a corresponding case. The code comment documents this intent. With TreatWarningsAsErrors, that warning would become a build error, which defeats the purpose (the failure mode would be "won't compile" rather than "developer is alerted to add a case"). The <NoWarn>CS8524</NoWarn> suppression is scoped to OpenClaw.Shared only and is documented in the csproj comment.

Test Status

All source projects build with 0 errors, 0 warnings after this change:

src/OpenClaw.Shared        ✅ 0 errors
src/OpenClaw.Connection    ✅ 0 errors
src/OpenClaw.Cli           ✅ 0 errors
src/OpenClaw.WinNode.Cli   ✅ 0 errors
src/OpenClaw.Chat          ✅ 0 errors

Shared test suite: 1950 passed, 8 pre-existing Linux/WSL infrastructure failures (unchanged from baseline).

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@97143ac59cb3a13ef2a77581f929f06719c7402a

[clawsweeper]

Codex review: needs changes before merge.

Latest ClawSweeper review: 2026-05-23 13:09 UTC / May 23, 2026, 9:09 AM ET.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The PR adds TreatWarningsAsErrors to src/Directory.Build.props and adds a project-level CS8524 NoWarn in OpenClaw.Shared.

Reproducibility: yes. Source inspection shows OpenClaw.CommandPalette has its own closer Directory.Build.props, while the PR only adds TreatWarningsAsErrors to the parent props and adds CS8524 suppression at project scope.

PR rating
Overall: 🦐 gold shrimp
Proof: 🌊 off-meta tidepool
Patch quality: 🦐 gold shrimp
Summary: The PR has a useful build-hardening goal, but two concrete policy gaps keep the patch below merge-ready quality.

Rank-up moves:

• Cover src/OpenClaw.CommandPalette/Directory.Build.props or explicitly document that source-project exception.
• Replace the project-level CS8524 NoWarn with a narrowly scoped suppression around the intentional switch.
• Rerun the repository-required build and test validation after the repair.

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Not applicable: This is a generated bot PR, so the external-contributor real-behavior proof gate does not apply; the PR body still reports build and test output as supplemental validation.

Risk before merge

• The PR body reports source builds for five projects and omits OpenClaw.CommandPalette, so the posted validation does not prove the stated all-source warning policy.
• The project-wide CS8524 suppression can hide future non-exhaustive enum switch expressions anywhere in OpenClaw.Shared, weakening the same build discipline the PR is adding.
• This read-only review did not run the repo build or tests because the task forbids commands that write build artifacts.

Maintainer options:

1. Make the build policy coherent before merge (recommended)
   Add the warning-as-error policy to CommandPalette's local props, narrow the CS8524 exception to the intentional switch, and rerun the required build and test validation.
2. Explicitly accept narrower enforcement
   Maintainers can choose to exempt CommandPalette or keep the project-wide CS8524 suppression, but the PR should document that as an intentional policy exception.
3. Pause in favor of a smaller build-policy PR
   If the warning policy needs more maintainer discussion, close or pause this generated branch and replace it with a narrower human-reviewed build configuration change.

Copy recommended automerge instruction

@clawsweeper automerge

Special instructions:
Add TreatWarningsAsErrors to src/OpenClaw.CommandPalette/Directory.Build.props, replace the OpenClaw.Shared project-level CS8524 NoWarn with a narrow local suppression around the intentional ExecApprovalsCoordinator switch, and run the repository-required build/test validation.

Next step before merge
The blockers are narrow build-configuration repairs that an automated PR repair lane can attempt without a product decision.

Security
Cleared: The diff changes MSBuild warning policy only and does not add dependencies, scripts, action refs, secret access, or downloaded code.

Review findings

• [P2] Extend warnings-as-errors to CommandPalette — src/Directory.Build.props:20
• [P2] Scope the CS8524 suppression to the intentional switch — src/OpenClaw.Shared/OpenClaw.Shared.csproj:13

Review details

Best possible solution:

Apply the warning-as-error policy consistently to all intended source projects and keep the CS8524 exception narrowly scoped to the one intentional switch.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows OpenClaw.CommandPalette has its own closer Directory.Build.props, while the PR only adds TreatWarningsAsErrors to the parent props and adds CS8524 suppression at project scope.

Is this the best way to solve the issue?

No. The maintainable version should cover the nested CommandPalette source project and localize the CS8524 exception instead of suppressing that warning throughout OpenClaw.Shared.

Label changes:

• add P2: This is a normal-priority build-hardening PR with limited runtime blast radius, but it has concrete merge-blocking policy gaps.
• add merge-risk: 🚨 automation: The PR changes build failure policy and can make CI/developer builds stricter while still leaving one source project and one compiler warning path inconsistently handled.
• add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: This is a generated bot PR, so the external-contributor real-behavior proof gate does not apply; the PR body still reports build and test output as supplemental validation.

Label justifications:

• P2: This is a normal-priority build-hardening PR with limited runtime blast radius, but it has concrete merge-blocking policy gaps.
• merge-risk: 🚨 automation: The PR changes build failure policy and can make CI/developer builds stricter while still leaving one source project and one compiler warning path inconsistently handled.
• rating: 🦐 gold shrimp: Current PR rating is 🦐 gold shrimp because proof is 🌊 off-meta tidepool, patch quality is 🦐 gold shrimp, and The PR has a useful build-hardening goal, but two concrete policy gaps keep the patch below merge-ready quality.
• status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: This is a generated bot PR, so the external-contributor real-behavior proof gate does not apply; the PR body still reports build and test output as supplemental validation.

Full review comments:

• [P2] Extend warnings-as-errors to CommandPalette — src/Directory.Build.props:20
OpenClaw.CommandPalette has its own closer Directory.Build.props, and this file's comment says MSBuild stops there. Adding TreatWarningsAsErrors only here leaves that source project able to build with compiler warnings even though the PR claims all source projects are enforced.
  Confidence: 0.91
• [P2] Scope the CS8524 suppression to the intentional switch — src/OpenClaw.Shared/OpenClaw.Shared.csproj:13
  Putting CS8524 in project-level NoWarn disables the non-exhaustive enum-switch warning for every current and future switch expression in OpenClaw.Shared. The exception is only justified for the documented ExecApprovalsCoordinator switch, so use a local suppression or another narrow mechanism there.
  Confidence: 0.88

Overall correctness: patch is incorrect
Overall confidence: 0.9

Acceptance criteria:

• ./build.ps1
• dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore
• dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore

What I checked:

• PR diff adds the parent source warning policy: The PR adds TreatWarningsAsErrors to src/Directory.Build.props, but that file itself documents that OpenClaw.CommandPalette has a closer Directory.Build.props and does not inherit this parent file. (src/Directory.Build.props:20, 0b51aed6bb0c)
• CommandPalette remains outside the policy: The PR head leaves src/OpenClaw.CommandPalette/Directory.Build.props without TreatWarningsAsErrors, so the CommandPalette source project is not covered by the new parent policy. (src/OpenClaw.CommandPalette/Directory.Build.props:1, 0b51aed6bb0c)
• Project-wide CS8524 suppression: The PR suppresses CS8524 in the whole OpenClaw.Shared project, not just the intentional ExecApprovalsCoordinator switch described in the PR body and source comment. (src/OpenClaw.Shared/OpenClaw.Shared.csproj:13, 0b51aed6bb0c)
• Intentional switch site: Current main documents one intentional non-exhaustive switch in ExecApprovalsCoordinator; source search shows many other switch expressions exist under OpenClaw.Shared, which would also lose CS8524 coverage under the project-wide suppression. (src/OpenClaw.Shared/ExecApprovals/ExecApprovalsCoordinator.cs:146, 5a87c9921c31)
• No maintainer notes found: No .agents/maintainer-notes files were present for the touched areas. (5a87c9921c31)
• Build props provenance: The current source and test build props were introduced through merge commit 3d16bac, including the existing test-side TreatWarningsAsErrors policy that this PR mirrors. (tests/Directory.Build.props:13, 3d16bac78fec)

Likely related people:

• Scott Hanselman: The current main blame and merge metadata for the shared build props point to merge commit 3d16bac, which introduced the source and test Directory.Build.props files. (role: merger / recent area contributor; confidence: medium; commits: 3d16bac78fec; files: src/Directory.Build.props, src/OpenClaw.CommandPalette/Directory.Build.props, tests/Directory.Build.props)
• bkudiess: The merged feature branch referenced by commit 3d16bac introduced the source and CommandPalette build props plus the test warnings-as-errors policy. (role: original branch contributor; confidence: medium; commits: df1ab27b3c42, 3d16bac78fec; files: src/Directory.Build.props, src/OpenClaw.CommandPalette/Directory.Build.props, tests/Directory.Build.props)
• AlexAlves87: Commit 12416d2 introduced ExecApprovalsCoordinator and the intentional non-exhaustive switch that the PR is trying to accommodate. (role: feature owner; confidence: high; commits: 12416d282a23; files: src/OpenClaw.Shared/ExecApprovals/ExecApprovalsCoordinator.cs, tests/OpenClaw.Shared.Tests/ExecApprovalsCoordinatorTests.cs)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 5a87c9921c31.

[clawsweeper]

ClawSweeper PR egg

🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress.

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

• Merged PRs are hatchable.
• Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
• Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

What is this egg doing here?

• Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
• The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
• Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
• The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
• Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.