Skip to content

feat(tray): consistent back-links across cross-page navigations#521

Open
bkudiess wants to merge 1 commit into
openclaw:masterfrom
bkudiess:back-buttons
Open

feat(tray): consistent back-links across cross-page navigations#521
bkudiess wants to merge 1 commit into
openclaw:masterfrom
bkudiess:back-buttons

Conversation

@bkudiess
Copy link
Copy Markdown
Contributor

@bkudiess bkudiess commented May 23, 2026

Adds consistent "← Back to {origin}" links across cross-page navigations in the Hub, extending the existing pattern used on Sessions/Instances/Permissions. Page names are reused from the existing sidebar localizations, so only two new resw keys were added (BackToOriginFormat, BackToOriginGeneric.Text) translated across all five locales.

Opening Chat from Sessions intentionally does not show a back link — Chat is a destination, not a sub-page.

Connections that now show a back link

From To
About (Info) Diagnostics
Channels Config (×2)
Permissions Voice & Audio
Chat (settings gear) Voice & Audio
Bindings Connection
Cron Connection
Usage Connection
Diagnostics Connection
Instances (pending-pair banner) Connection
Connection Sessions
Connection Instances
Connection Permissions

The last three already existed on master; the rest are new in this PR.

Validation

  • ./build.ps1 ✅
  • Shared tests: 1891 passed, 29 skipped ✅
  • Tray tests: 1196 passed ✅

feat(tray): consistent back-links across cross-page navigations
1773fef 
Extended the existing 'Back to Connection' affordance (Sessions/Instances/
Permissions) to every cross-page link in the Hub so users always have a
one-click return path.

- Added Helpers/NavOriginLabels for nav-tag -> display-label mapping so
  destination pages can render 'Back to {origin}' dynamically.
- Threaded originTag through 9 cross-page Navigate calls: About->Debug,
  Channels->Config (x2), Permissions->Voice, and Bindings/Cron/Usage/
  Debug/Instances->Connection.
- Added the inline back HyperlinkButton + Initialize-time wiring to
  ConfigPage, VoiceSettingsPage, DebugPage, and ConnectionPage matching
  the existing Sessions/Instances/Permissions pattern.
- Updated AsyncListLoadingPageWiringTests to accept the originTag-bearing
  Navigate('connection', ...) signature.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@clawsweeper
Copy link
Copy Markdown

clawsweeper Bot commented May 23, 2026 •
edited
Loading

Codex review: needs real behavior proof before merge.

Latest ClawSweeper review: 2026-05-23 01:10 UTC / May 22, 2026, 9:10 PM ET.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
Adds localized "Back to {origin}" links to Config, Connection, Diagnostics, and Voice Hub pages, threads origin tags through selected cross-page navigations, and updates a tray source-wiring test.

Reproducibility: not applicable. this is a feature PR, not a bug report with a failing current-main reproduction path. Source inspection verifies the existing origin-navigation contract and the PR diff's intended extension points.

PR rating
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Summary: The patch looks focused and source-consistent, but the PR is not quality-ready until visible real behavior proof is added.

Rank-up moves:

  • Add a redacted screenshot or short recording showing the new Back to origin links for representative Hub flows and the hidden state for direct rail navigation.
  • Update the PR body after adding proof so ClawSweeper re-reviews automatically; if it does not, ask a maintainer to comment @clawsweeper re-review.
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Needs real behavior proof before merge: No after-fix screenshot, recording, live output, or redacted log is present; add a short redacted Hub proof to the PR body so ClawSweeper can re-review, or ask a maintainer to comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Mantis proof suggestion
A short desktop visual proof would materially help verify the new Hub back-link behavior and hidden state. A maintainer can ask Mantis to capture proof by posting a new PR comment that starts with the OpenClaw Mantis account mention, followed by:

visual task: verify the Hub shows Back to origin links for Config, Connection, Diagnostics, and Voice origin-tagged navigations, and hides them for direct rail navigation.

Risk before merge

  • No after-fix screenshot, recording, live output, or redacted log shows the visible Hub back-link behavior, so layout and navigation-state confidence is limited until proof is added.
  • The build and test results are contributor-reported; this read-only review did not independently run validation commands that would create build artifacts.

Maintainer options:

  1. Decide the mitigation before merge
    Land the focused Hub navigation polish after contributor-provided real UI proof shows the new back links appear for origin-tagged flows and stay hidden for direct navigation.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
Contributor-supplied real behavior proof is the next blocker; ClawSweeper cannot repair or prove that setup for them.

Security
Cleared: The diff only touches tray UI navigation, localization resources, and a source-level test assertion; I found no concrete security or supply-chain concern.

Review details

Best possible solution:

Land the focused Hub navigation polish after contributor-provided real UI proof shows the new back links appear for origin-tagged flows and stay hidden for direct navigation.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a feature PR, not a bug report with a failing current-main reproduction path. Source inspection verifies the existing origin-navigation contract and the PR diff's intended extension points.

Is this the best way to solve the issue?

Yes, pending proof: extending LastNavigationOrigin keeps this on the existing Hub navigation model instead of adding a second source of navigation state. A reusable component could reduce duplication later, but the current patch is narrow enough for this UX change.

Label changes:

  • add P3: This is low-risk tray UX polish for cross-page navigation ergonomics rather than a blocking runtime defect.
  • add rating: 🧂 unranked krab: Current PR rating is 🧂 unranked krab because proof is 🧂 unranked krab, patch quality is 🐚 platinum hermit, and The patch looks focused and source-consistent, but the PR is not quality-ready until visible real behavior proof is added.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: No after-fix screenshot, recording, live output, or redacted log is present; add a short redacted Hub proof to the PR body so ClawSweeper can re-review, or ask a maintainer to comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Label justifications:

  • P3: This is low-risk tray UX polish for cross-page navigation ergonomics rather than a blocking runtime defect.
  • rating: 🧂 unranked krab: Current PR rating is 🧂 unranked krab because proof is 🧂 unranked krab, patch quality is 🐚 platinum hermit, and The patch looks focused and source-consistent, but the PR is not quality-ready until visible real behavior proof is added.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: No after-fix screenshot, recording, live output, or redacted log is present; add a short redacted Hub proof to the PR body so ClawSweeper can re-review, or ask a maintainer to comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

What I checked:

Likely related people:

  • bkudiess: Git history ties the current LastNavigationOrigin contract and existing inline back-link pattern to 9c9f705, and this PR extends that same area. (role: introduced behavior and adjacent contributor; confidence: high; commits: 9c9f70565076; files: src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml.cs, src/OpenClaw.Tray.WinUI/Pages/SessionsPage.xaml.cs, src/OpenClaw.Tray.WinUI/Pages/InstancesPage.xaml.cs)
  • Scott Hanselman: Recent main history and blame show connection-page and back-link line movement through connection page polish and merges around the same Hub navigation surface. (role: recent area contributor; confidence: medium; commits: a0be8519df4b, 8714381248a2; files: src/OpenClaw.Tray.WinUI/Pages/ConnectionPage.xaml.cs, src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml.cs)
  • Christine Yan: Recent merged work touched Chat and Usage behavior that this PR routes from or back to, making them a useful adjacent reviewer if navigation side effects appear there. (role: adjacent Chat/Usage surface contributor; confidence: low; commits: cd4acf0, 488f265; files: src/OpenClaw.Tray.WinUI/Pages/ChatPage.xaml.cs, src/OpenClaw.Tray.WinUI/Pages/UsagePage.xaml.cs)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 8714381248a2.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. labels May 23, 2026
@clawsweeper
Copy link
Copy Markdown

clawsweeper Bot commented May 23, 2026

ClawSweeper PR egg

🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?
  • The egg game starts only after the PR passes the real-behavior proof check.
  • Before that, no creature or rarity is rolled. The treat waits for real proof.
  • This is still just collectible flavor: proof affects review readiness, not creature quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bkudiess