Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Workflows #215

Merged
merged 17 commits into from
Nov 24, 2023
Merged

Dynamic Workflows #215

merged 17 commits into from
Nov 24, 2023

Conversation

ferishili
Copy link
Contributor

This PR fixes #13

Description

see description in issue.

Solution

Now configuration panel is loaded, converted into ILIAS style and presented to users directly from Opencast, so you will have dynamic parameters to interact with and then those values will be sent back to opencast.

the whole concept/approach is that:

Admins:

  • Plugin setting tab "Workflows" now contains 2 sub-tabs! (Settings & Workflow definitions list)
  • Admin must set the workflow tags to extract from the list of workflow definitions from Opencast.
  • Admins are able view/edit/delete those extracted workflows in the definitions list sub-tab
  • Admins are able to define translations string for each workflow definition option in the Start Workflow list selection by providing workflow_selection_text_{workflow definition identifier} e.g. workflow_selection_text_{republish-metadata}#:#Veröffentlicht in the lang strings.
  • Admins are able to reset or update the list of workflow definitions by two provided button in the in the definitions list sub-tab.

Users:

  • When the list is set by admin, users will have "Start Workflow" button in the event Action menu.
  • The modal with a dropdown to select configured workflows will be displayed and users are able to select one.
  • Description of that wf will be displayed now (if any)
  • Configuration Panel of selected WF will be displayed (if any)
  • Users are able to interact with configuration panel and enter values etc.

NOTE:

This PR increase the plugin version to 5.3.2 and a db update No. 43, so it might have conflicts with current PRs!

@ferishili ferishili self-assigned this Nov 14, 2023
@ferishili ferishili added the enhancement New feature or request label Nov 14, 2023
@dagraf
Copy link
Contributor

dagraf commented Nov 16, 2023

I did some testing and can confirm that our workflows work as expected.

But I would strongly suggest some design optimizations (see mockup for a suggestion):

  • Use the same font for the description and configuration as for "workflow". Write the titles in bold.
  • Titles: (i) Do not write "Description" but use the name of the workflow as title.
  • Bring everything on two different lines: (i) First line: Left align everything that is written. (ii) Second line: The input fields should begin on the same line.
  • Bring the description and the title of the "Configuration panel" (please rename to EN: "Settings", DE: "Einstellungen") a bit closer together.

@ferishili: What do you think of this suggestions?

Before:
Bildschirmfoto 2023-11-16 um 14 36 03

After:
Bildschirmfoto 2023-11-16 um 14 55 03

@ferishili
Copy link
Contributor Author

Thanks a lot @dagraf. I am going apply the changes ASAP

@ferishili
Copy link
Contributor Author

Hi @dagraf,
new changes are pushed, please have a look. Thanks.

@dagraf
Copy link
Contributor

dagraf commented Nov 20, 2023

Thanks for the changes, which look good. Only the "Configuration Panel" is not yet renamed. But for the moment I suggest we leave it as it is and change the wording at a later stage.

Therefore and @Amstutz: Can you please review this PR and comment it if needed or merge it. Thx!

@ferishili
Copy link
Contributor Author

ferishili commented Nov 20, 2023

Thank you.
PS: The Configuration Panel is renamed, you only need to refresh the languages again 😄

@dagraf
Copy link
Contributor

dagraf commented Nov 20, 2023

Renaming of Configuration Panel: I did refresh the languages but maybe some cache settings is playing a trick on me. I will retest later and comment here if needed.

@reiferschris
Copy link
Contributor

Hi @dagraf, new changes are pushed, please have a look. Thanks.

I also tested the changes to the configuration panel with our workflows, they look fine. Thanks for coming up with the improvement @dagraf and @ferishili

@chfsx chfsx assigned chfsx and unassigned ferishili Nov 23, 2023
@chfsx
Copy link
Contributor

chfsx commented Nov 23, 2023

PR in elan-ev#4 to resolve conflicts

@chfsx chfsx mentioned this pull request Nov 23, 2023
@chfsx chfsx merged commit 53b4e8b into opencast-ilias:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definable workflow parameters
4 participants