CADC-14233 - regression fix for CFHT edge cases #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 93.56% 93.64% +0.07%
==========================================
Files 26 26
Lines 8678 8689 +11
==========================================
+ Hits 8120 8137 +17
+ Misses 558 552 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andamian
reviewed
Jun 5, 2025
|
|
||
| def _to_float(value): | ||
| return float(value) if value is not None else None | ||
| try: |
Contributor
There was a problem hiding this comment.
This changes the whole meaning of the function and can break existing functionality (if it exists). IMO, a better way would be to have a different method _extract_float(value) or similar which would imply best effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.