OBPIH-6686 Add tests for using keyboard shortcuts on receiving table #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
requested changes
Jan 31, 2025
| ninthProductService, | ||
| }) => { | ||
| const supplierLocation = await supplierLocationService.getLocation(); | ||
| const PRODUCT_ONE = await mainProductService.getProduct(); |
There was a problem hiding this comment.
Is this required if you are using just product ids later? Why there is a need to fetch a product through API? Additionally, looking at the .getProduct() it is fetching product demand that seem to be unnecessary here.
| PRODUCT_FOUR=productId | ||
| PRODUCT_FIVE=productId | ||
| PRODUCT_SIX=productId |
There was a problem hiding this comment.
Please just limit this to five products. For these reasons:
- You don't need all 10 products to test the arrows
- This approach is inefficient
- I am not adding secrets for dozen of different products to the repo
- we need to have a better approach overall for such scenarios (does not have to be figured out in this ticket/pr)
| PRODUCT_EIGHT=productId | ||
| PRODUCT_NINE=productId | ||
| PRODUCT_TEN=productId |
There was a problem hiding this comment.
Please add a new line at the end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for using keyboard shortcuts on receiving table: receiving now and comment columns