core: render remote environment cwd natively#28152
Merged
Merged
Conversation
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
167b3b9 to
5baa76a
Compare
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
3fc8e16 to
b91a6db
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
2 times, most recently
from
6144dc1 to
68d1d00
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
3 times, most recently
from
7ed4c97 to
0d74265
Compare
This was referenced Jun 16, 2026
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
5 times, most recently
from
0b0db42 to
8ca024f
Compare
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
b91a6db to
c5d7b2b
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
8ca024f to
d900fb5
Compare
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
c5d7b2b to
4e7f589
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
d900fb5 to
cbe850c
Compare
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
4e7f589 to
514b62e
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
reviewed
Jun 16, 2026
pakrym-oai
reviewed
Jun 16, 2026
pakrym-oai
approved these changes
Jun 16, 2026
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
cbe850c to
efb3ceb
Compare
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
514b62e to
54304e5
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
de366e5 to
166ad66
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
166ad66 to
b5ed455
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
b5ed455 to
42b4b7e
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
42b4b7e to
c5fabde
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
b6c0886 to
be6caaa
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
c5fabde to
d7de7ef
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
be6caaa to
fa970c1
Compare
anp-oai
force-pushed
the
codex/remote-windows-path-requirements
branch
from
d7de7ef to
6afd483
Compare
anp-oai
commented
Jun 16, 2026
Collaborator
|
@codex review this |
Contributor
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
anp-oai
added a commit
that referenced
this pull request
Jun 17, 2026
## Why #28152 jumped the gun on moving the rollout format to store URIs, and would likely break compat with some features that don't go through the same types as the core logic. ## What Make `TurnContextItem.cwd` an `AbsolutePathBuf` again, remove test added for `PathUri` serialization in rollouts. Also drops a bunch of error paths that are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Model-visible
<environment_context>should match the environment of the executor, not of the app server.Stacked on #28146.
What
PathUriwhile building environment context.TurnContextItem.cwdvalues when reconstructing and diffing context.powershellandC:\windows.